Skip to content
This repository has been archived by the owner on Sep 1, 2022. It is now read-only.

trimDirectiveWhitespaces breaking GetTransect #1366

Open
markhepburn opened this issue Aug 13, 2021 · 3 comments
Open

trimDirectiveWhitespaces breaking GetTransect #1366

markhepburn opened this issue Aug 13, 2021 · 3 comments
Assignees

Comments

@markhepburn
Copy link

The GetTransect implementation outputs coordinates as space-separated coordinates:
https://github.com/Unidata/thredds/blob/4.6.x/tds/src/main/webapp/WEB-INF/jsp/wms/showTransect_xml.jsp#L33

The included xml_header adds the trimWhitespaceDirectives attribute, which has the effect of removing the space between the two numbers. Changing it to false produces the expected output.

I'm assuming something has changed, perhaps jasper treating expression-language statements as directives. I'm using:

  • Java 1.8
  • Tomcat 9.0.50.0
  • Thredds-4.6.16.1
@lesserwhirls
Copy link
Collaborator

lesserwhirls commented Aug 16, 2021

@ethanrd - thoughts?

@markhepburn
Copy link
Author

(Just weighing in so you don't think I've dropped this and run -- I do have plans to do try older versions of tomcat, if not an informal bisection. I'm obviously happy if someone can save me the trouble though :))

@markhepburn
Copy link
Author

Having another quick look at this, and same issue with Tomcat 8.5.70.

I also just tried on a random public thredds server with the same result.

I'm happy to create a PR that removes the trimDirectiveWhitespaces, but it seems odd that this hasn't been detected up until now! (I get that it is non-standard functionality, and possibly not broadly used). Presumably at some point it was working, and I'm assuming something external changed in order to break it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants