This repository has been archived by the owner on Sep 1, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 179
Not detecting _FillValue of scaled data correctly #1065
Comments
Fixed in #1067. Thanks for the report! |
Perfect, thanks. Would you be able to cut a |
Hi @guygriffiths - I'll cut a second beta release later today or tomorrow and this change will be in there :-) |
@guygriffiths - sorry for the delay on our end! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
This comes from a bug report for EDAL (Reading-eScience-Centre/edal-java#109).
In the test data available at that bug report, the fill values are not being detected properly. The variable
tmp
is stored as an integer and has a_FillValue
of99999
and ascale_factor
of1.e-05
. By the time we get to theisMissing_()
method in ucar.nc2.dataset.EnhanceScaleMissingImpl, the value has been scaled to0.99999
. However, when that method callsisFillValue()
on that, it returnsfalse
, since it is testing against the unscaled value (i.e. 99999).The text was updated successfully, but these errors were encountered: