Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows Testers #22

Closed
mitchellkrogza opened this issue Aug 19, 2017 · 73 comments
Closed

Windows Testers #22

mitchellkrogza opened this issue Aug 19, 2017 · 73 comments

Comments

@mitchellkrogza
Copy link
Member

Please can any windows users test the Windows version and also the install and update batch script and report back here. Many thanks.

@xxcriticxx
Copy link

link to test file please

@mitchellkrogza
Copy link
Member Author

mitchellkrogza commented Aug 19, 2017

That's both an installer and updater script

@mitchellkrogza
Copy link
Member Author

Latest hosts file tested on an old Windows XP machine and working 100% does require that DNS client service is disabled and name servers for network connection set manually to 8.8.8.8 and 8.8.4.4.... Can confirm this works and should work on all versions of Windows

@mitchellkrogza
Copy link
Member Author

Any Windows 10 testers out there ?

@xxcriticxx
Copy link

Me this weekend if I don't forget

@mitchellkrogza
Copy link
Member Author

mitchellkrogza commented Aug 23, 2017

@xxcriticxx awesome looking forward to the feedback. Can you believe this thing actually frikking works on an old XP SP 2 ???

@xxcriticxx
Copy link

@mitchellkrogza do you have uninstall script just in case?

@mitchellkrogza
Copy link
Member Author

I'll add one into the repo now.

@mitchellkrogza
Copy link
Member Author

@xxcriticxx
Copy link

@hawkeye116477 can you please test this on windows computer

@hawkeye116477
Copy link

hawkeye116477 commented Aug 23, 2017

@xxcriticxx Rather no, because I very rarely use Windows. Maybe @MajkiIT or @gzenio22?

@xxcriticxx
Copy link

@hawkeye116477 maybe lets see if they show up over here

@MajkiIT
Copy link

MajkiIT commented Aug 24, 2017

@mitchellkrogza I tested this script and I see this alert https://www.screencast.com/t/zF15Fq3V . Of course I opened CMD with Admin privileges.

@mitchellkrogza
Copy link
Member Author

mitchellkrogza commented Aug 24, 2017

@MajkiIT thanks sorry I made a change in the install-update script, please pull latest version and try again.

@MajkiIT
Copy link

MajkiIT commented Aug 24, 2017

@mitchellkrogza this message is to me ? sorry my bad .... corrected it

@mitchellkrogza
Copy link
Member Author

@MajkiIT
Copy link

MajkiIT commented Aug 24, 2017

@mitchellkrogza
Copy link
Member Author

mitchellkrogza commented Aug 24, 2017 via email

@mitchellkrogza
Copy link
Member Author

mitchellkrogza commented Aug 24, 2017 via email

@xxcriticxx
Copy link

@MajkiIT is this on vm machine or real windows machine?

@xxcriticxx
Copy link

pc win7

install http:https://imgur.com/a/ynQWt
uninstall http:https://imgur.com/a/0c354

@mitchellkrogza
Copy link
Member Author

@xxcriticxx so it worked??

@MajkiIT
Copy link

MajkiIT commented Aug 25, 2017

@xxcriticxx
Win7 is VM
Win 10 i real

@xxcriticxx
Copy link

@mitchellkrogza i see errors in the install script

@mitchellkrogza
Copy link
Member Author

Thanks @xxcriticxx @MajkiIT I found the syntax error had a instead of a "
Latest commit Fixes this > 8695f9f

Busy testing on Windows 10 and it no longer has the syntax error issue.

@mitchellkrogza
Copy link
Member Author

Don't know what your project is about or what you are paying people for because for testing dead domains it's already done with all the work @funilrys has put into funceble.... With me constantly asking for new features LOL

@MajkiIT
Copy link

MajkiIT commented Aug 28, 2017

@mitchellkrogza I want to find dead domains. I want to learn something so I want to find best and fast way. I pay them about 20$ . I want to analyse code and it's all. Next releases I will do it.

@MajkiIT
Copy link

MajkiIT commented Aug 28, 2017

@mitchellkrogza I look for this file and It's ok, but you use whois but I think, that is limit od whois requests. Maybe better is use DNS request to find that domain is resolved.

@mitchellkrogza
Copy link
Member Author

funceble does nslookups, whois checks and checks the page status 200, 301, 302, 404 etc and all in 2 seconds per domain. @funilrys

@mitchellkrogza
Copy link
Member Author

Have a good and proper look at funceble @funilrys has put so much work into it and I've kept asking for features, kept finding bugs and it's now truly unbeatable

@MajkiIT
Copy link

MajkiIT commented Aug 28, 2017

@mitchellkrogza I know. I don't want to say that is bad IDEA. I think that it's very good work, but I want to find another solution. I try to use script on Linux and I have 10 domain per seconds.

@mitchellkrogza
Copy link
Member Author

But you are getting blocked for too many lookups. You say 22 days and this cleaning output will be finished in 9 without being blocked.

@MajkiIT
Copy link

MajkiIT commented Aug 28, 2017

I was blocked because I push request to 1 server. I say 2 weeks, because developers will finish code. I tested 1800 domains in 2-3 minutes by linux script without ban.

@funilrys
Copy link
Member

To stop the discussion and continue in a constructive way @MajkiIT can you give us a flowchart of your project(s)?

Here's the last of mine (many changes since then but it's really clear) ...
global_funceble

@MajkiIT
Copy link

MajkiIT commented Aug 28, 2017

here is my bash script ==> https://github.com/MajkiIT/Work/blob/master/dead_domain.sh
The same solution I want to use in .Net Core and PHP.

@funilrys
Copy link
Member

funilrys commented Aug 28, 2017

Well, we are at two different level then ...
@mitchellkrogza comments/answers are legitimate then because funceble is actually a level higher ... (Please report to his comments above)

Did you pay someone for that? 😱

@MajkiIT
Copy link

MajkiIT commented Aug 28, 2017

In my way I want find best way to dead domains. I run script ones a day and writes scores to file.
No, I write this script in 2 minutes and I local solution. I want to .net or php to web app.

@xxcriticxx
Copy link

@MajkiIT thank you for showing up. i would like to introduce my two best friends :0

@funilrys
Copy link
Member

Well, there's some limitation into PHP but it's not impossible ... Actually, Python will even be better than PHP or .net I think ... I don't know .net for now (gonna learn it if I come back to windows one day 😹 )

To precise, I wrote it in bash/shell because I found that it'll be cool, I love Linux (especially Arch and Gentoo) and I wanted something that would be useful in a world that we have 1M line hosts file with only 500K active ...

And yeah I don't mind the time it takes the most accurate results only count for now 👅 😹

But yeah it'll be interesting to see the PHP solutions 🤔

@xxcriticxx
Copy link

@mitchellkrogza when is the next raw build coming?

@funilrys
Copy link
Member

In a week @xxcriticxx 😸

@MajkiIT
Copy link

MajkiIT commented Aug 28, 2017

@funilrys but Linux scripts you run on server not by web /http/ . I want to do it be web page.

@xxcriticxx
Copy link

@funilrys list is good not i only found one false positive

@funilrys
Copy link
Member

@MajkiIT I actually works not on a web app which would be impossible for 1 Million domains because of the PHP timeout but on funilrys/funceble#62 which will come as a complement of funceble for deep analytic ... It's the only issue that is not implemented to the dev as it needs many times ...

But yeah it'll be interesting to have a web page or even better a GUI app which is one of my future projects :)

@xxcriticxx
Copy link

cool thx @funilrys

@MajkiIT
Copy link

MajkiIT commented Aug 28, 2017

@funilrys I want to run process on N servers, for example 5 . Divide the file by the number of servers and run 10 php process by server .

@funilrys
Copy link
Member

Okay now I understand @xxcriticxx comment at funilrys/funceble#90 (comment) 😄 For me it's not the solution but I don't have time to debate ... Gonna see what your developers produce if you put it on a repo. Otherwise Python can be used to create webapp too ... The world is not only around PHP ...

@mitchellkrogza
Copy link
Member Author

@xxcriticxx @MajkiIT @xxcriticxx I'll start another thread regarding this.

Please let's keep this issue only for discussing Windows Testing.

@mitchellkrogza
Copy link
Member Author

mitchellkrogza commented Aug 29, 2017

@xxcriticxx

If you want daily updated lists of bad sites for now, just use below. There will only be a new raw update on this list next week.

Just add these to your pi-hole until then. (note: once this repo is updated you will not need to pull from below repo's as they will be included when daily updates resume)

https://github.com/mitchellkrogza/Badd-Boyz-Hosts/blob/master/PULL_REQUESTS/domains.txt

https://github.com/mitchellkrogza/The-Big-List-of-Hacked-Malware-Web-Sites/blob/master/.dev-tools/_strip_domains/domains.txt

@xxcriticxx
Copy link

@mitchellkrogza once per week is ok with me just let me know when to pull

@mitchellkrogza
Copy link
Member Author

mitchellkrogza commented Aug 29, 2017

@xxcriticxx I will most certainly update you all when the new RAW links are updated next week. Based on current stats when I push the update next week we will lose already 23% of dead domains from the list. I will monitor this daily. Oh yes ... and thanks for the lively debate here last night. Sorry I stopped responding as I am seriously under the weather with the anti-biotic I am on that the dentist gave me, feel like it's killing me

@xxcriticxx
Copy link

xxcriticxx commented Aug 29, 2017

@mitchellkrogza stop getting high and back to work chop chop

@mitchellkrogza
Copy link
Member Author

🤣 🤣 @xxcriticxx you know you are quite a slave driver, but I love it ...... always making sure you keep me on my toes

@xxcriticxx
Copy link

@mitchellkrogza thats how i know i have good list

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants