Invalid host names #129
Comments
|
Well thanks to you @Odyseus for reporting !! 👍🌟 @mitchellkrogza I think that we both (Py||Funceble && Ultimate) have to review the way we handle those typos or invalid domains ! Thanks again @Odyseus 👍🌟 P.S: I added this to my workflow for future commit or update of Py||Funceble. |
|
Hello, @funilrys. I'm just glad that I could be of some help. 👍 I found these invalid host names while developing my own Hosts Manager application (a CLI app written in Python). I investigated a little more about valid host names and I found some more invalid host names. The following table list the host names as found on the hosts file that can be found in this repository, the possible error/s and the possibly correct host name.
(1): This is a character that looks like the minus sign. The following is a table with info from the GNOME Character Map application about the possibly invalid character.
In case that it could be useful, here is the Python 3 function that I use to check for valid host names. #!/usr/bin/python3
import re
HOSTNAME_REGEX = re.compile(r"(?!-)[\w-]{1,63}(?<!-)$")
def is_valid_host(host):
"""IDN compatible domain validation.
"""
host = host.rstrip(".")
return all([len(host) > 1, len(host) < 253] + [HOSTNAME_REGEX.match(x) for x in host.split(".")])This function is based on several functions that I found in this StackOverflow question. I just mainly translated it into a one-liner. The function basically does the following:
Side note 1: The explanation above is based on my own understanding. Since I'm not a professional developer of any kind, I could be horribly wrong. LOL Side note 2: The regular expression is outside the function for performance reasons.
|
|
this would be great add to any tool i think |
|
@xxcriticxx and @Odyseus I will get this in the works early next week |
|
@mitchellkrogza you slacking lately :( |
|
@xxcriticxx been a rough start to the year and had a loss in the family so I've been out of town for a while but back in action. Have no fear all issues will be addressed. |
|
@mitchellkrogza We are sorry to hear that :( |
|
@mitchellkrogza sorry my friend |
|
Hello @Odyseus @mitchellkrogza , Thanks to this issue I discovered an issue in PyFunceble. Please note that I reinforced the way check for an inactive domain with the previously referenced patch. So that way @mitchellkrogza, we can work efficiently when we are going to do further structure development. @Odyseus I did not use your snippets but as you indirectly contributed, into that patch, I would like, if you accept, to add you to the list of PyFunceble's contributors. Thanks again. Cheers, Before the patch
After the patch
|
|
Hello, everybody. @funilrys: Thanks for the thought, but don't feel obligated to do so. I'm just happy to contribute however I can to any open source initiative. 👍 I looked at the code on your patch and, in case that it could be useful for you to know, I also use a function to validate IP addresses. It uses the ipaddress module from Python's standard library. It checks for both IP types (IPv4 and IPv6), but it would be easy to just check for IPv4 only. from ipaddress import ip_address
def is_valid_ip(address):
"""Validate IP address (IPv4 or IPv6).
Parameters
----------
address : str
The IP address to validate.
Returns
-------
bool
If it is a valid IP address or not.
"""
try:
ip_address(address)
except ValueError:
return False
return TrueI'm pretty sure that I got this function from StackOverflow, but the exact source got lost in my browsing history. |
Hello, everybody.
I have found what seems to be invalid host names.
Note that I said "seems to be" because I'm not entirely sure if all of the listed host names are invalid. It's for the experts to decide.
Thanks for your work, @mitchellkrogza and contributors. 👍
The text was updated successfully, but these errors were encountered: