Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when you edit ranks in organization table, sorting the table will undo the changes #87

Closed
6 tasks
ehinman opened this issue Aug 23, 2023 · 1 comment · Fixed by #91
Closed
6 tasks

Comments

@ehinman
Copy link
Contributor

ehinman commented Aug 23, 2023

Describe the bug

  1. Go to org table
  2. Edit ordering
  3. ctrl-enter to save changes
  4. then try to sort ordering column by new rank - table resets and loses all of user's changes

To Reproduce

Steps to reproduce the behavior:

1. Go to '...'

2. Click on '....'

3. Scroll down to '....'

4. See error

Please include your Water Quality Portal data query inputs from the Load
data tab:

If applicable, include code to reproduce the behavior:

library(TADAShiny)
TADAShiny::run_app()

Expected behavior

A clear and concise description of what you expected to happen.

Screenshots

If applicable, add screenshots to help explain your problem.

Session Info

Please include your session info:

sessionInfo()
#OR preferred:
devtools::session_info()

Additional context

Add any other context about the problem here.

Reminders for TADA contributors addressing this issue

New features should include all of the following work:

  • Create the function/code.

  • Document all code using comments to describe what is does.

  • Create tests in tests folder.

  • Create help file using roxygen2 above code.

  • Create working examples in help file (via roxygen2).

  • Add to appropriate vignette (or create new one).

@ehinman
Copy link
Contributor Author

ehinman commented Aug 23, 2023

This is the issue in the mod_overview.R page:

observeEvent(input$overview_orgtable_cell_edit, {
org_rank = data.frame(OrganizationIdentifier = mapdat$orgs$OrganizationIdentifier, Rank = as.numeric(input$overview_orgtable_cell_edit$value)) %>% dplyr::arrange(Rank)
tadat$orgs = org_rank$OrganizationIdentifier
})

The input$overview_orgtable_cell_edit needs to refresh the table: mapdat$orgs

@ehinman ehinman linked a pull request Aug 25, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant