-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TADA.ComparableDataIdentifier is used for legend labels in TADA_TwoCharacteristicScatterplot uses a different column for id_cols #485
Comments
Should we limit the columns that can be used for id_cols? |
Below is an example of a scatterplot I modified for a demo. See (https://usepa.github.io/EPATADA/articles/TADAWaterSciConWorkshopDemo.html) if you want to see how to create the data set used in the example below. Maybe it would be possible to conditionally remove the 2nd y-axis if the same characteristic is plotted in both traces? But base the scale on both traces? What do you think of changing the name to TADA_TwoGroupScatterplot? That might be more descriptive if we are making it flexible enough to accommodate different id_cols inputs. Or is this starting to get so convoluted that it may make sense to create a separate function for comparing different locations rather than different characteristics? We could discuss tomorrow. `# create two characteristic scatterplot using TADA_TWoCharacteristicScatterplot remove default plot features that are not applicable for a location comparisonplotly::layout(yaxis2 = list(overlaying = "y", side = "right", title = "", visible = FALSE), create two characteristic scatterplot using TADA_TWoCharacteristicScatterplottwochar_scatter <- TADA_TwoCharacteristicScatterplot(data %>% remove default plot features that are not applicable for a location comparisonplotly::layout(yaxis2 = list(overlaying = "y", side = "right", title = "", visible = FALSE), ![]() |
Made some edits to the function for TADA_TwoCharacteristicScatterplot. Currently, I decided to stick with just one function rather than creating a new function. However, depending on thoughts with this update, a decision can be made if this should be separated into two different functions instead.
`data <- data %>% Remove geometry to reduce size of data setsf::st_drop_geometry() %>% Assing "Other" as name for unnamed assessment unitsdplyr::mutate(ATTAINS.assessmentunitname =
|
Describe the bug
TADA.ComparableDataIdentifier is used for the legend labels in TADA_TwoCharacteristicScatterplot even when a different column has been selected for id_cols. This is confusing when comparing the same characteristic between two monitoring locations, for example:
To Reproduce
Expected behavior
Labels for the legend should reflect the column selected in id_cols.
Bug fixes should include all the following work:
Create or edit the function/code.
Document all code using line/inline and/or multi-line/block comments
to describe what is does.
Create or edit tests in tests/testthat folder to help prevent and/or
troubleshoot potential future issues.
Create or edit the function documentation. Include working
examples.
Update or add the new functionality to the appropriate vignette
(or create new one).
If function/code edits made as part of this issue impact other
functions in the package or functionality in the shiny app, ensure
those are updated as well.
Run TADA_UpdateAllRefs(), TADA_UpdateExampleData(), styler::style_pkg(),
devtools::document(), and devtools::check() and address any new notes or
issues before creating a pull request.
Run more robust check for releases: devtools::check(manual = TRUE,
remote = TRUE, incoming = TRUE)
The text was updated successfully, but these errors were encountered: