Convert to Python3 #112
Open
Convert to Python3 #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrgp
suggested changes
Sep 2, 2017
| if not isinstance(app, cherrypy.Application): | ||
| continue | ||
| if not app.config: | ||
| continue | ||
| if sn == '': | ||
| continue | ||
| sn_atoms = sn.strip("/").split("/") | ||
| for key in app.config.keys(): | ||
| for key in list(app.config.keys()): |
There was a problem hiding this comment.
This could be the following instead which is faster as when iterated over dicts simply return their keys:
for key in app.config:
| @@ -91,7 +91,7 @@ def check_site_config_entries_in_app_config(self): | |||
|
|
|||
| def check_skipped_app_config(self): | |||
| """Check for mounted Applications that have no config.""" | |||
| for sn, app in cherrypy.tree.apps.items(): | |||
| for sn, app in list(cherrypy.tree.apps.items()): | |||
There was a problem hiding this comment.
Casting the generator returned by .items() to a list is going to make the for loop slower.
Not since Python 3.5 :D |
|
This should be reconsidered given Python2 reaching end-of-life in January. |
|
I expect to have time in december to work on that.
Le 16/11/2019 à 18:35, nekokatt a écrit :
… This should be reconsidered given Python2 reaching end-of-life in January.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#112>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAMYVXWPMUOPBVEEI44UB6LQUAVM3ANCNFSM4DL24TZA>.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
using : find . -name '*.py' | xargs 2to3 -w