-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Open Telemetry #157
Comments
Hi @Turnerj Just my 2 cents on this - I wouldn't tightly bind your lib to Open Telemetry - instead I think an approach of providing something like an These could be things like (off the top of my head - I'm sure there could be many more!):
By default there would be a This way an Open Telemetry implementation could be built, or indeed, any other roll-your-own, or of the shelf system could easily be supported. The consumer just needs to wire up a concrete implementation of CacheMonitor which ties into their monitoring system. |
Thanks for the feedback @mgoodfellow ! Everything you've said makes sense and is probably what I should do. Similarly doing it that method allows for integration with event counters too. Depending on the access points needed to support it, I should be able to achieve this through my extension system (even if it requires new "hook" points). |
Open Telemetry has reached v1 and may be worth directly supporting in Cache Tower.
See: https://medium.com/opentelemetry/opentelemetry-specification-v1-0-0-tracing-edition-72dd08936978
Further investigation required.
The text was updated successfully, but these errors were encountered: