Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the torrent grouping feature based on names #7986

Merged
merged 1 commit into from
Apr 19, 2024
Merged

Remove the torrent grouping feature based on names #7986

merged 1 commit into from
Apr 19, 2024

Conversation

drew2a
Copy link
Contributor

@drew2a drew2a commented Apr 18, 2024 •
edited
Loading

This PR disables the torrent grouping feature based on torrent names as was requested by @synctext.
The feature has been introduced in

image

@drew2a drew2a mentioned this pull request Apr 18, 2024
Closed
@drew2a drew2a marked this pull request as ready for review April 18, 2024 14:28
@drew2a drew2a requested review from a team, xoriole and kozlovsky and removed request for a team April 18, 2024 14:29
kozlovsky
kozlovsky approved these changes Apr 19, 2024
View reviewed changes
Copy link
Contributor

@kozlovsky kozlovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, now unused group_by_name field should be removed from SearchResultsModel and RemoteTableModel.

@drew2a drew2a merged commit f33d198 into Tribler:release/7.14 Apr 19, 2024
16 checks passed
@drew2a drew2a deleted the fix/remove_similar_groups branch April 19, 2024 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xoriole xoriole xoriole approved these changes

@kozlovsky kozlovsky kozlovsky approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@drew2a @xoriole @kozlovsky