Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix core crashed error because of existing running core #7924

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

xoriole
Copy link
Contributor

@xoriole xoriole commented Mar 1, 2024

Based on the current architecture, the GUI spawns the core process and maintains its lifecycle. However, that is not always the case for some unclear reasons as reported on user sentry reports (links below). Evident from the reports is that there is still a core process running in the background which prevents any successful attempt to run Tribler again unless the core process is somehow terminated. This leads to bad user experience with repeated crash reports.

The purpose of this PR is to change how we handle the cases where there is an existing core process. Instead of crashing on user that there is an existing core process with which the GUI cannot talk to and simply crash. With the changes proposed on this PR, GUI shall try to connect to such existing core process, however, would not (or could not) the lifecycle of the core process.

With the merge of this PR, it will address the following issues. To be specific, the listed issues occur if the core process spawned by the GUI is terminated abruptly (eg. sys.exit(code)). The PR only addresses for the case where the exit code is EXITCODE_ANOTHER_CORE_PROCESS_IS_RUNNING:97.

@xoriole xoriole marked this pull request as ready for review March 1, 2024 17:22
@xoriole xoriole requested review from a team and egbertbouman and removed request for a team March 1, 2024 17:22
@xoriole xoriole merged commit 8882155 into Tribler:main Mar 4, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants