Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #7345 by suppressing
ConnectionResetError
.ConnectionResetError
can be raised in three cases:https://github.com/aio-libs/aiohttp/blob/29b6f302ad6736f71ef3fb029d4c5bac786a2fb7/aiohttp/http_writer.py#L69-L76
In all cases described above, we cannot do anything from the core side. All reconnect logic is on the GUI side.
The most probable root cause of the error is the situation in which the GUI goes through the shutdown procedure and closes the connection with the core. For this particular case,
ConnectionResetError
should be ignored on the core side anyway.There is another way to fix the issue (@kozlovsky suggestion).
However, this fix requires much more work, increases the complexity of the GUI-core interactions, and involves Sentry for suppressing the specific error.
Since this is not a critical issue to address, it is better to fix it in the most straightforward and simple way.