Ignore old responses for the DownloadsPage #7391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aab3189
to
1d833bf
Compare
drew2a
commented
Apr 26, 2023
| @@ -34,9 +34,10 @@ def __init__(self, limit: int = 50, timeout_interval: int = 15): | |||
| self.protocol = DEFAULT_API_PROTOCOL | |||
| self.host = DEFAULT_API_HOST | |||
| self.port = DEFAULT_API_PORT | |||
| self.key = b"" | |||
| self.key = '' | |||
There was a problem hiding this comment.
It seems like a bug that became visible after I wrote the tests. It's not directly related to the PR.
732cb18
to
b3dac11
Compare
kozlovsky
approved these changes
Apr 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to #7360 and continues the work done in #7378.
It adds an id for each Request on the GUI side. This new functionality is utilized in the DownloadsPage to ignore outdated requests.