Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tribler translation to Spanish #7235

Closed
wants to merge 1 commit into from
Closed

Add Tribler translation to Spanish #7235

wants to merge 1 commit into from

Conversation

Manuel-Senpai
Copy link
Contributor

Hi:
I have translated Tribler to Spanish, I have uploaded the files "es_ES.ts" and "es_ES.qm "and also the web file "https://github.com/Tribler/tribler#readme" renamed as "README.es.rst", if everything is ok, I hope you can include them in the next version.
Best regards

Hi:
I have translated Tribler to Spanish, I have uploaded the files "es_ES.ts" and "es_ES.qm "and also the web file "https://github.com/Tribler/tribler#readme" renamed as "README.es.rst", if everything is ok, I hope you can include them in the next version.
Best regards
@Manuel-Senpai Manuel-Senpai requested review from a team and kozlovsky and removed request for a team December 26, 2022 12:16
@tribler-ci
Copy link
Contributor

Can one of the admins verify this patch?

@synctext
Copy link
Member

| Conexiones máximas por descarga

Thnx for that X-mas contribution! This seems like days of work?

@Manuel-Senpai
Copy link
Contributor Author

Manuel-Senpai commented Dec 30, 2022

Hi guys:
Sorry for the question, I'm a newbie in Gibhub and I have no idea about programming or how this goes, can the translation be added to Tribler?, is there something wrong and I have to change it?, I tell you I'm very lost around here..... ;-)

Copy link
Contributor

@kozlovsky kozlovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Manuel-Senpai thank you for this translation!

We cannot add the Spanish README translation, as it would be very hard to maintain README in multiple languages. It is already a bit obsolete and needs to be updated from the English version, so it does not worth having it.

But the other files look good! For us to be able to accept the PR, you need to rebase it against the current main branch, remove the README translation, and move other files to src/tribler/gui/i18n subdirectory. Can you do it? Or, I can do it for you.

@Manuel-Senpai
Copy link
Contributor Author

Hi @kozlovsky:
Better if you do it... I don't want to break anything, hahaha, I've been trying to delete the "README.es.rst" and I still don't quite understand the steps....
Tell me if you need any data to do it
Best regards

@kozlovsky
Copy link
Contributor

kozlovsky commented Jan 2, 2023

Thank you @Manuel-Senpai, the translation was merged in #7246

@kozlovsky kozlovsky closed this Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants