Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix initialization of Ipv8Endpoint in RESTComponent #7044

Merged
merged 1 commit into from
Sep 9, 2022
Merged

Fix initialization of Ipv8Endpoint in RESTComponent #7044

merged 1 commit into from
Sep 9, 2022

Conversation

kozlovsky
Copy link
Contributor

RESTComponent should not add /ipv8 endpoint if Ipv8Component is not available.

The current code in the main branch has a bug - it tries to handle the situation, but still creates /ipv8 endpoint in this case

@kozlovsky kozlovsky requested review from a team and drew2a and removed request for a team September 9, 2022 13:39
@kozlovsky kozlovsky merged commit 7c012f0 into Tribler:main Sep 9, 2022
@kozlovsky kozlovsky deleted the fix/ipv8_endpoint branch September 9, 2022 14:18
@kozlovsky kozlovsky mentioned this pull request Sep 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drew2a drew2a drew2a approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kozlovsky @drew2a