Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal for Improving Error Reporting Mechanism in Sentry #8051

Closed
drew2a opened this issue Jun 3, 2024 · 2 comments
Closed

Proposal for Improving Error Reporting Mechanism in Sentry #8051

drew2a opened this issue Jun 3, 2024 · 2 comments

Comments

@drew2a
Copy link
Contributor

drew2a commented Jun 3, 2024

We have the very first Sentry issue reported by @xoriole's new mechanism for error reporting.

The great news is that it is working, and the mechanism can be improved further.

Currently, the formatting of the Event is as follows:
image

This links together two issues:

OSError
[WinError 1] Incorrect function: 'Z:\\Tribler\\lib\\aiohttp_apispec\\static'[<relief>-core PID:3512] 2024-06-03 00:13:38,464 - ERROR <exception_handler:141> CoreExceptionHandler.unhandled_error_observer(): Save the error to later report

and

CoreCrashedError
The Tribler core has unexpectedly finished with exit code 1 and status: 0.

The real issue with the stack trace is buried somewhere inside the event:
image

My proposition is that the real issue with its stack trace should be easily accessible in the report and should not be substituted by CoreCrashedError.
Also, it seems that the excessive core output is captured for the issue description:

[WinError 1] Incorrect function: 'Z:\\Tribler\\lib\\aiohttp_apispec\\static'[<relief>-core PID:3512] 2024-06-03 00:13:38,464 - ERROR <exception_handler:141> CoreExceptionHandler.unhandled_error_observer(): Save the error to later report

Where the necessary part is

[WinError 1] Incorrect function: 'Z:\\Tribler\\lib\\aiohttp_apispec\\static'

and the excessive is

[<relief>-core PID:3512] 2024-06-03 00:13:38,464 - ERROR <exception_handler:141> CoreExceptionHandler.unhandled_error_observer(): Save the error to later report

Related:

@drew2a drew2a changed the title Format Sentry issue Proposal for Improving Error Reporting Mechanism in Sentry Jun 3, 2024
@drew2a drew2a assigned drew2a and unassigned xoriole Jun 4, 2024
@drew2a
Copy link
Contributor Author

drew2a commented Jun 4, 2024

@drew2a drew2a assigned xoriole and unassigned drew2a Jun 4, 2024
@xoriole xoriole removed their assignment Aug 19, 2024
@xoriole
Copy link
Contributor

xoriole commented Aug 19, 2024

As QT based UI is removed from the main codebase, this issue has become obsolete. Therefore, I'm unassigning myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants