Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[main] Tribler switches to the "search results" page with a single click on the Search Bar. #6660

Closed
drew2a opened this issue Dec 16, 2021 · 4 comments · Fixed by #8048
Closed

[main] Tribler switches to the "search results" page with a single click on the Search Bar. #6660

drew2a opened this issue Dec 16, 2021 · 4 comments · Fixed by #8048
Assignees
@drew2a
Labels
type: bug
Milestone
7.15.0

Comments

@drew2a
Copy link
Collaborator

drew2a commented Dec 16, 2021

Describe the bug
Tribler switches to the "search results" page with a single click on the Search Bar.

To Reproduce
Steps to reproduce the behavior:

  1. Open Tribler
  2. Search for something (eg "Ubuntu")
  3. Go to the "Discovered" page
  4. Click on the search bar

Expected behavior
My expectation is that my current page should not change. But it changes to the "Search results" page.

Screenshots
image
image

Desktop (please complete the following information):

  • OS: macOS Monterey
  • Tribler's version 7.11
@devos50
Copy link
Contributor

devos50 commented Dec 16, 2021

This was an intentional change so we could remove the 'search results' from the left menu. The inspiration from this came from a previous iteration in the Spotify UI where they also used this approach.

@drew2a do you think it's too intuitive? If so, we could consider placing back the 'search results' button in the left menu.

@drew2a
Copy link
Collaborator Author

drew2a commented Dec 16, 2021

Hmm... I have never seen this behavior before, although I use Spotify from time to time.

But I'm ok with it if it is a "common practice".

@devos50
Copy link
Contributor

devos50 commented Dec 16, 2021

Hmm... I have never seen this behavior before, although I use Spotify from time to time.

Well, it actually seems that Spotify changed this recently. They now have a 'search' button in their left menu, and clicking on the search bar does not bring me back to the results anymore. 😁

@ichorid
Copy link
Contributor

ichorid commented Dec 16, 2021

Yep, they changed it recently. But they removed the search bar from the top too. Do we want to do the same change?

@drew2a drew2a self-assigned this Jun 3, 2024
@drew2a drew2a added this to the 7.15.0 milestone Jun 3, 2024
@drew2a drew2a mentioned this issue Jun 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@drew2a drew2a

Labels
type: bug
Projects
None yet
Milestone
7.15.0
Development

Successfully merging a pull request may close this issue.

Remove search bar click event drew2a/tribler
3 participants
@devos50 @ichorid @drew2a