Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the version of PyInstaller for macOS. #7782

Closed
drew2a opened this issue Dec 14, 2023 · 0 comments · Fixed by #8004
Closed

Update the version of PyInstaller for macOS. #7782

drew2a opened this issue Dec 14, 2023 · 0 comments · Fixed by #8004
Labels
type: enhancement
Milestone
7.15.0

Comments

@drew2a
Copy link
Collaborator

drew2a commented Dec 14, 2023

We use a pinned version of PyInstaller (4.2 released: Jan 13, 2021) for macOS: https://pypi.org/project/pyinstaller/4.2/.

tribler/build/mac/makedist_macos.sh

Lines 24 to 25 in f17ed57

python3 -m pip install pip==23.0.1 # pin pip version to avoid "--no-use-pep517" issues with the latest version
python3 -m pip install PyInstaller==4.2 --no-use-pep517

All modern versions of PyInstaller still don't work with our build script (see #7484; my last attempt was with 5.13.2 and 6.3.0 in #7781).

As the build script uses the pinned version of PyInstaller, we are exposed to risks of bugs and vulnerabilities that are fixed in the modern version but still exist in this one. Also, at one point, the older version will not work on modern macOS, and we will need to change it anyway.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: enhancement
Projects
None yet
Milestone
7.15.0
Development

Successfully merging a pull request may close this issue.

Clean up the macos build dependencies drew2a/tribler
1 participant
@drew2a