Suppress ValueError on EventsEndpoint at shutdown #7906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drew2a
approved these changes
Feb 19, 2024
There was a problem hiding this comment.
Suppressing errors in the finally block does seem a bit extreme to me.
Since there are no return statements in the try block, I would suggest rewriting the block as follows:
try:
while not self._shutdown:
await asyncio.sleep(1)
except CancelledError:
self._logger.warning('Event stream was canceled')
else:
self._logger.info('Event stream was closed due to shutdown')
with suppress(ValueError):
self.events_responses.remove(response)(NIT)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ValueError is raised at the shutdown stage so suppressing the error is acceptable.
Fixes #7905