Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix remote search #7896

Merged
merged 3 commits into from
Feb 12, 2024
Merged

Fix remote search #7896

merged 3 commits into from
Feb 12, 2024

Conversation

xoriole
Copy link
Contributor

@xoriole xoriole commented Feb 9, 2024

There are two issues addressed in this PR:

  1. The request parameters included a deprecated parameter exclude_deleted. This parameter is popped out when doing the actual search on the metadata store now.
  2. The metadata_type in the request parameter is received as string '300' which on conversion to json was turning it to list [3, 0, 0]. Since channels are removed, there is only one metadata type which is a single string, a simple integer conversion should be sufficient if the value is of string type.

Out of scope of this PR:

  1. This PR does not address removing the deprecated parameter exclude_deleted from the remote search endpoint call from the GUI side.
  2. Still the search query processing logic checks if the metadata_type is either an integer or list of integers. Since there is only one metadata type available, this logic should be changed. This change is out of scope for this PR.

Fixes #7893

@xoriole xoriole marked this pull request as ready for review February 12, 2024 10:40
@xoriole xoriole requested a review from a team as a code owner February 12, 2024 10:40
@xoriole xoriole requested review from drew2a and removed request for a team February 12, 2024 10:40
@xoriole xoriole merged commit 06b12af into Tribler:main Feb 12, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remote search does not yield any results
2 participants