ValueError: Can redirect only to http or https

[sentry-for-tribler]

Sentry Issue: TRIBLER-13Z

ValueError: Can redirect only to http or https
  File "tribler\core\components\restapi\rest\rest_manager.py", line 53, in error_middleware
  File "aiohttp\web_middlewares.py", line 117, in impl
  File "tribler\core\components\libtorrent\restapi\torrentinfo_endpoint.py", line 102, in get_torrent_info
  File "tribler\core\components\libtorrent\restapi\torrentinfo_endpoint.py", line 39, in query_http_uri
  File "aiohttp\client.py", line 624, in _request

Last Seen
3 days ago
in release 7.13.1

First Seen
10 months ago
in release 7.12.1

EVENTS
11

USERS
3

[drew2a]

The following actions are performed:

1. The user inputs http:https://tinyurl.com/<url>.
2. This URL is resolved to a magnet link magnet:?xt=urn:sha1:....
3. The magnet link causes a ValueError in query_http_uri.

[drew2a]

@qstokkink, what do you think about the safety of allowing redirects in Tribler?

I can either:
a) Allow redirects.
b) Return a human-readable error stating that we do not support redirects.

[qstokkink]

I consider the existence of this issue to be evidence that redirection is a feature that our users want. Based on that, my vote goes to a) allow redirects.

[drew2a]

aiohttp supports redirection out-of-the-box, but it cannot work with schemes other than "http", "https", "".

The error occurred here:

https://github.com/aio-libs/aiohttp/blob/6529c77551e2a61d6d9df72653df92180d1fed7c/aiohttp/client.py#L609-L611

                        if scheme not in ("http", "https", ""):
                            resp.close()
                            raise ValueError("Can redirect only to http or https")

This is because, in our case, the scheme is magnet.

Refs:

• Implement a better way of handling non-HTTP urls in client.ClientSession aio-libs/aiohttp#2507
• ValueError when redirecting to URL with incorrect schema aio-libs/aiohttp#3315

[drew2a]

I've implemented the desired feature, but it turns out that the magnet link shortened by TinyURL cannot be parsed by our parse_magnetlink. However, the same magnet link is successfully parsed by https://github.com/JohnDoee/magnet2torrent but the extracted hash can not be used with the BitTorrent as it seems to be incompatible (has urn:sha1 and urn:ed2khash but not urn:btih).