Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anonymous download performance enhancements #7684

Closed
egbertbouman opened this issue Nov 9, 2023 · 6 comments · Fixed by #7908
Closed

Anonymous download performance enhancements #7684

egbertbouman opened this issue Nov 9, 2023 · 6 comments · Fixed by #7908
Assignees

Comments

@egbertbouman
Copy link
Member

egbertbouman commented Nov 9, 2023

I'm currently doing some performance enhancements to our core, in particular to the IPv8 socket/tunnel community. By moving some code to rust (Tribler/py-ipv8#1119), we're getting much better download speeds:

rust_25mb

@synctext
Copy link
Member

synctext commented Nov 9, 2023

25.5 MByte/sec download speed 💥
Real results, after starting abandoned experiments in 2019: #4567
Prior 2019 code: https://github.com/ip-v8/rust-ipv8
🚀

@ichorid
Copy link
Contributor

ichorid commented Nov 19, 2023

I wonder how much of increase that will be, if you move both sides of the tunnel (e.g. tunnel helpers too) to Rust... 🤩

@egbertbouman egbertbouman self-assigned this Nov 20, 2023
@egbertbouman
Copy link
Member Author

I don't really expect to see speeds beyond what I'm currently seeing. If I look at the speed with just a single circuit, it won't go beyond 3MB/s. So, while testing, I worked around the issue by creating 20 circuits.
At 25MB/s the most CPU intensive thread will use a full core at the downloader side. Of course, it all depends on which machine you use.

@synctext
Copy link
Member

synctext commented Jan 8, 2024

As discussed in Dev Meeting...this month, Jan 2024 all Rust matters on both IPv4 and IPv6 should come together. Stable performant code is the ambition.

@egbertbouman
Copy link
Member Author

IPv8 has now been refactored to support a separate Rust endpoint (Tribler/py-ipv8#1250). There is also a release on PyPI.

@qstokkink
Copy link
Contributor

For the occasion, I gave the Rust implementation a run on my bare metal machine (AMD Ryzen Threadripper 3970X 32-Core, 64 GB 2666 MHz RAM, from an M2 drive with a gigabit Internet connection).

As a benchmark, using the same torrent, I gathered three results that are more-or-less repeatable:

  • A 0 hop download using the Libtorrent 2.0.7 "simple client" C implementation: the maximum we can achieve with Tribler.
  • A 0 hop download using "Tribler Experimental" and Libtorrent 1.2.19 with everything switched off except the download manager, IPv8, and the tunnel community.
  • A 1 hop download using "Tribler Experimental" and Libtorrent 1.2.19 with everything switched off except the download manager, IPv8, and the tunnel community.

Here are the screenshots:

Libtorrent 2.0.7 C implementation +- 110 MB/s

simpleclient 0 hops

Tribler 0 hops +- 67.5 MB/s

Tribler 0 hops

Tribler Rust 1 hop anonymous +- 27.5 MB/s

Tribler 1 hop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants