-
Notifications
You must be signed in to change notification settings - Fork 445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pytest-timeout is not working as expected when pytest-rerunfailures is enabled #7581
Comments
The example provided in the issue works well with @pytest.mark.timeout(2)
@pytest.mark.flaky(0)
def test_new():
time.sleep(10)
assert True Perhaps if we run our tests with this argument, The tests should be run with the following env:
|
Seems that we still have tests that could not be stopped by https://github.com/Tribler/tribler/actions/runs/6812737385/job/18525760881?pr=7685 The |
pytest-timeout
is not working well withpytest-rerunfailures
.See: pytest-dev/pytest-timeout#18
Because of this, the default timeout of 60 seconds is not applied on the tests and sometimes some tests get stuck for several minutes resulting in GitHub action's execution timeout of 10 minutes.
One of the such tests is
test_check_and_regen_personal_channel_torrent_sleep
which was stuck for approx 8 minutes.Logs here: https://github.com/Tribler/tribler/actions/runs/5937813183/job/16103116115?pr=7575
Link might not be available for long so here is the relevant logs snippet:
So, I would be in favor of disabling
pytest-rerunfailures
so we can find out the tests which are getting stuck and fix them properly.The text was updated successfully, but these errors were encountered: