A patch for asyncio.tasks.wait_for for Python 3.8-3.11
#7572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Impressive as always! Just a question to understand how 'deep' this is. |
|
@synctext I think setting up the stress testing should require a day of work. I'd like first to spend a day fixing the broken metrics collection and dashboard, and then I can do the stress testing. |
|
OK, then it's a lot of your time. Lets try to get a stable release |
96a8404
to
5480455
Compare
drew2a
approved these changes
Aug 16, 2023
5480455
to
89f077e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The patch fixes #7570 by monkey-patching
asyncio.tasks.wait_forwith a version that did not suppressCancelledError. Also, the patched version addsbase_lost_result_handlerthat writes an error if a result of a completed task is lost due to a race condition. Right now, I don't think we have some lost resources due to the originalwait_forbug, but later we can overridebase_lost_result_handlerto properly close such resources if necessary.