Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/language support script release #7411

Merged
merged 4 commits into from
Jul 21, 2023
Merged

Fix/language support script release #7411

merged 4 commits into from
Jul 21, 2023

Conversation

xoriole
Copy link
Contributor

@xoriole xoriole commented May 8, 2023 •
edited
Loading

Fixes #7403

qt5-default is removed from the dependency of language scripts because lrelease is available on qttools5-dev-tools.

user@user-pc:~/Downloads$ apt-file list qttools5-dev-tools
qttools5-dev-tools: /usr/lib/qt5/bin/designer
qttools5-dev-tools: /usr/lib/qt5/bin/lconvert
qttools5-dev-tools: /usr/lib/qt5/bin/linguist
qttools5-dev-tools: /usr/lib/qt5/bin/lprodump
qttools5-dev-tools: /usr/lib/qt5/bin/lrelease    <-----------this one --------
qttools5-dev-tools: /usr/lib/qt5/bin/lrelease-pro
qttools5-dev-tools: /usr/lib/qt5/bin/lupdate
qttools5-dev-tools: /usr/lib/qt5/bin/lupdate-pro
qttools5-dev-tools: /usr/lib/qt5/bin/pixeltool
...

The large changes are because of the re-extraction of the messages and updating the translation. This was done by executing the scripts. This also ensures that the script works.

cd src/tribler/gui/i18n
./extract-messages.sh
./update_translations.sh

@xoriole xoriole force-pushed the fix/language-support-script-release branch from 7ccd9d9 to e8a68ec Compare June 29, 2023 14:31
@xoriole xoriole changed the base branch from release/7.13 to main June 29, 2023 14:32
@xoriole xoriole force-pushed the fix/language-support-script-release branch 3 times, most recently from 4afbf0c to 0dca8b4 Compare July 20, 2023 09:12
@xoriole xoriole force-pushed the fix/language-support-script-release branch from 0dca8b4 to b6b5a3b Compare July 20, 2023 09:31
@xoriole xoriole self-assigned this Jul 20, 2023
@xoriole xoriole marked this pull request as ready for review July 20, 2023 09:54
@xoriole xoriole requested a review from a team as a code owner July 20, 2023 09:54
@xoriole xoriole requested review from kozlovsky and removed request for a team July 20, 2023 09:54
kozlovsky
kozlovsky approved these changes Jul 21, 2023
View reviewed changes
Copy link
Collaborator

@kozlovsky kozlovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good!

@xoriole xoriole merged commit ff7639b into Tribler:main Jul 21, 2023
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kozlovsky kozlovsky kozlovsky approved these changes

Assignees

@xoriole xoriole

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix translation support scripts with re-organization of languages.json file
2 participants
@xoriole @kozlovsky