Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove mocks of stdout and stderr #7156

Merged
merged 1 commit into from
Nov 14, 2022
Merged

Remove mocks of stdout and stderr #7156

merged 1 commit into from
Nov 14, 2022

Conversation

drew2a
Copy link
Collaborator

@drew2a drew2a commented Nov 9, 2022 •
edited
Loading

This PR fixes #7140

@kozlovsky made an investigation and found that the cause of the problem -- overflow in LogRotate function caused by the mocking of stderr.

@drew2a drew2a marked this pull request as ready for review November 9, 2022 16:24
@drew2a drew2a requested a review from a team as a code owner November 9, 2022 16:24
@drew2a drew2a requested review from kozlovsky and removed request for a team November 9, 2022 16:24
kozlovsky
kozlovsky requested changes Nov 10, 2022
View reviewed changes
src/tribler/core/logger/tests/test_logger.py Outdated Show resolved Hide resolved
src/tribler/core/logger/tests/test_logger.py Outdated Show resolved Hide resolved
@drew2a drew2a merged commit bb140fc into Tribler:main Nov 14, 2022
@drew2a drew2a deleted the fix/7140 branch November 14, 2022 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kozlovsky kozlovsky kozlovsky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Tests] AssertionError: Expected 'print' to be called once. Called 7551 times.
2 participants
@drew2a @kozlovsky