Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tribler is asking to upgrade version too frequently. #7077

Closed
vi opened this issue Oct 13, 2022 · 3 comments · Fixed by #7102
Closed

Tribler is asking to upgrade version too frequently. #7077

vi opened this issue Oct 13, 2022 · 3 comments · Fixed by #7102
Assignees
@drew2a
Labels
type: bug
Milestone
7.13.0

Comments

@vi
Copy link
Contributor

vi commented Oct 13, 2022

New version available
Version 7.12.1 of Tribler is available.Do you want to visit the website to download the newest version?
[Ignore] [Later] [OK]

I press "Later", expecting to see the notice again in a day or a week. But it seems to postpone it only by an hour or so.
@devos50 devos50 added this to the 7.12.0 milestone Oct 14, 2022
@devos50
Copy link
Contributor

devos50 commented Oct 14, 2022

Thanks for reporting! This seems to be a bit too aggressive indeed. We'll have a look at it.

@drew2a drew2a modified the milestones: 7.12.0, 7.13.0 Oct 14, 2022
@drew2a drew2a self-assigned this Oct 17, 2022
@drew2a
Copy link
Contributor

drew2a commented Oct 21, 2022

According to the code, the check should be postponed for 6 hours:

tribler/src/tribler/core/components/version_check/versioncheck_manager.py

Line 15 in c4d7d75

VERSION_CHECK_INTERVAL = 6 * 3600 # Six hours

@vi
Copy link
Contributor Author

vi commented Oct 21, 2022

Maybe postpone interval and usual update intervals should be separate?

@drew2a drew2a mentioned this issue Oct 21, 2022
Merged
vi added a commit to vi/tribler that referenced this issue Oct 21, 2022
@vi
Inhibit new version nag if postpone is pressed
daba5b1 
Inhibit showing new version notification for current GUI
session after postpone button is clicked.

Resolves Tribler#7077
@vi vi mentioned this issue Oct 21, 2022
Merged
vi added a commit to vi/tribler that referenced this issue Oct 21, 2022
@vi
Inhibit new version nag if postpone is pressed
4245064 
Inhibit showing new version notification for current GUI
session after postpone button is clicked.

Resolves Tribler#7077
vi added a commit to vi/tribler that referenced this issue Oct 21, 2022
@vi
Inhibit new version nag if postpone is pressed
1d7889a 
Inhibit showing new version notification for current GUI
session after postpone button is clicked.

Resolves Tribler#7077
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@drew2a drew2a

Labels
type: bug
Milestone
7.13.0
Development

Successfully merging a pull request may close this issue.

Inhibit new version nag if postpone is pressed vi/tribler
3 participants
@vi @devos50 @drew2a