Violation of Liskov Substitution Principle in RemoteTableModel

[drew2a]

Violation of LSP (which is considered bad practice) has been detected in

tribler/src/tribler-gui/tribler_gui/widgets/tablecontentmodel.py

Lines 265 to 287 in a77ee44

	def perform_query(self, **kwargs):
	"""
	Fetch results for a given query.
	"""
	self.query_started.emit()
	if 'first' not in kwargs or 'last' not in kwargs:
	kwargs["first"], kwargs['last'] = self.rowCount() + 1, self.rowCount() + self.item_load_batch
	if self.sort_by is not None:
	kwargs.update({"sort_by": self.sort_by, "sort_desc": self.sort_desc})
	txt_filter = to_fts_query(self.text_filter)
	if txt_filter:
	kwargs.update({"txt_filter": txt_filter})
	if self.max_rowid is not None:
	kwargs["max_rowid"] = self.max_rowid
	if self.hide_xxx is not None:
	kwargs.update({"hide_xxx": self.hide_xxx})
	rest_endpoint_url = kwargs.pop("rest_endpoint_url") if "rest_endpoint_url" in kwargs else self.endpoint_url
	TriblerNetworkRequest(rest_endpoint_url, self.on_query_results, url_params=kwargs)

Explanation

The function RemoteTableModel.perform_query uses attributes self.text_filter, self.hide_xxx, self.endpoint_url which are defined in ChannelContentModel class.

ChannelContentModel is a child class in relation to RemoteTableModel.

Refs:

• https://en.wikipedia.org/wiki/SOLID
• https://en.wikipedia.org/wiki/Liskov_substitution_principle

[qstokkink]

Tribler now has a web-based front end and this issue is no longer relevant.