Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure GUI dialogs are managed by the MainWindow instance. #6597

Closed
devos50 opened this issue Dec 1, 2021 · 1 comment
Closed

Make sure GUI dialogs are managed by the MainWindow instance. #6597

devos50 opened this issue Dec 1, 2021 · 1 comment

Comments

@devos50
Copy link
Contributor

devos50 commented Dec 1, 2021

Our usage of dialogs in the GUI code is inconsistent. Specifically, we are creating dialog objects in different widgets classes, which can lead to race conditions and other hidden errors. We suspect that this might be a reason for the (recent) instability of the GUI tests.

I propose to manage all dialogs centrally, i.e., by a single manager. This manager keeps track of the open dialogs and allows us, amongst other features, to close all open dialogs when shutting down. We can also improve the GUI tests by implementing a wait_for_dialog method and remove a few hard-coded timeouts in the process.

@qstokkink
Copy link
Contributor

Tribler now has a web-based front end and this issue is no longer relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

3 participants