Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crazy dangerous database API #5692

Closed
synctext opened this issue Oct 27, 2020 · 2 comments
Closed

Crazy dangerous database API #5692

synctext opened this issue Oct 27, 2020 · 2 comments
Labels
type: bug
Milestone
Backlog

Comments

@synctext
Copy link
Member

synctext commented Oct 27, 2020 •
edited
Loading

We have an open database endpoint for any query. This is very generic and make Tribler very fragile.
This makes us vulnerable for a packet of death.

However, it makes debugging easy!
@synctext synctext added this to the Backlog milestone Oct 27, 2020
@ichorid
Copy link
Contributor

ichorid commented Oct 27, 2020

Well, not for any query, definitely. Only for select queries of a very strict form.

@ichorid
Copy link
Contributor

ichorid commented Oct 27, 2020

So, I don't see any problem here.

@ichorid ichorid closed this as completed Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
2 participants
@synctext @ichorid