Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Soft-crash of all 7.5.2 instances (Mac,Linux) #5670

Closed
synctext opened this issue Oct 22, 2020 · 6 comments · Fixed by #5695
Closed

Soft-crash of all 7.5.2 instances (Mac,Linux) #5670

synctext opened this issue Oct 22, 2020 · 6 comments · Fixed by #5695

Comments

@synctext
Copy link
Member

With a historic bug we might have managed to kill off all online instances of Tribler 7.5.2

Every online Tribler peers running 7.5.2 (reproduced on Ubuntu and Mac) who conducts a New_Tribler_Version() check has a popup window which overwrites the default Tribler GUI from which there is no escape:
Screenshot from 2020-10-22 17-34-34
Both the "Ignore" and the "Later" button do not make the blocking popup go away. The "OK" button opens a new browser window on both Ubuntu and Mac successfully, but does not close the popup. Open questions: is this also happening on Windows?

@devos50
Copy link
Contributor

devos50 commented Oct 22, 2020

I am unable to reproduce this on both my Mac and the Win10-64bit machine in proxmox.

@synctext
Copy link
Member Author

On Linux I just discovered I was running: tribler_7.5.2-2-g33fa321bb_all.deb.

@xoriole
Copy link
Contributor

xoriole commented Oct 22, 2020

I think it is because there are multiple popup stacked. Not sure how that happened since the version check duration is 6 hours unless it is running for a long time.

To reproduce the issue, I tried reducing the version check duration to a few seconds and I had a similar screen quickly. The popup should be a singleton and dispose any previous popus.

@ichorid
Copy link
Contributor

ichorid commented Oct 22, 2020

Installed 7.5.2 on Ubuntu 20.04, everything works fine 🤷

@synctext
Copy link
Member Author

synctext commented Oct 23, 2020

I think it is because there are multiple popup stacked. Not sure how that happened since the version check duration is 6 hours unless it is running for a long time.

Great to hear this! That could explain a lot. Tribler usually runs for at least a week. For past 15 years its been often in the background on one or two laptops.

Capturing these cornercases has consistently been hard. For many years we needed an easier way for our users to report bug and capture state in detail.

Can we have a unit test reproducing the multiple popups?

@xoriole
Copy link
Contributor

xoriole commented Oct 28, 2020

Can we have a unit test reproducing the multiple popups?

#5700 includes a test for it

@xoriole xoriole closed this as completed Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants