Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tribler tests should use the succeed/fail from IPv8 #5572

Closed
devos50 opened this issue Sep 18, 2020 · 0 comments · Fixed by #5573
Closed

Tribler tests should use the succeed/fail from IPv8 #5572

devos50 opened this issue Sep 18, 2020 · 0 comments · Fixed by #5573
Labels
type: enhancement
Milestone
7.6.0 November: S...

Comments

@devos50
Copy link
Contributor

devos50 commented Sep 18, 2020

It seems that the succeed and fail methods are defined twice, in utilities.py and in IPv8. Since IPv8 is already a dependency of IPv8, we should use the methods from IPv8 and remove the definitions from Tribler.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: enhancement
Projects
None yet
Milestone
7.6.0 November: Stability, usability,...
Development

Successfully merging a pull request may close this issue.

Convert the Tribler core tests to pytest devos50/tribler
1 participant
@devos50