Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: Tribler/tribler Loading
base: 34262051999ff931553cfcf232c1657110b1063b
Choose a base ref
...
head repository: Tribler/tribler Loading
compare: ede809a79211d3ad8d0fb12b0acee6d284712a7b
Choose a head ref
  • 1 commit
  • 2 files changed
  • 1 contributor

Commits on May 23, 2024

  1. Refactor proxy settings and add error handling 

    Reworked the 'set_proxy_settings' function in the download manager to handle invalid port values more gracefully. The function now attempts to convert the port value to an integer and logs any ValueError exceptions that occur during this process. This prevents crashes when non-integer values are provided for the port. Also, reorganized import statements according to PEP8 guidelines.

Additionally, a new test case 'test_set_proxy_settings_invalid_port' has been added to verify this behavior. It checks if proxy settings are not set when an invalid port number is provided.
    @drew2a
    drew2a committed May 23, 2024
    Configuration menu
    Copy the full SHA
    ede809a View commit details
    Browse the repository at this point in the history
Loading