Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add support for building and deploying Cloud Run Jobs #252

Open
tolgap opened this issue Apr 15, 2024 · 5 comments
Open

[Feature] Add support for building and deploying Cloud Run Jobs #252

tolgap opened this issue Apr 15, 2024 · 5 comments

Comments

@tolgap
Copy link
Contributor

tolgap commented Apr 15, 2024

We have support for Cloud Run Services. But I'm also utilizing Cloud Run Jobs which I would like to deploy via Nx 👍 .

@TriPSs
Copy link
Owner

TriPSs commented Apr 15, 2024

Would be a cool addition, could you create a PR?

Think a easy flag with type: 'default' | 'job' should be able to cover it right?

@tolgap
Copy link
Contributor Author

tolgap commented Apr 18, 2024

@TriPSs i think the options for the command is quite different from a Cloud Run Service. It would "pollute" the Cloud Run Service deploy executor.

@TriPSs
Copy link
Owner

TriPSs commented Apr 18, 2024

That's quite possible, haven't checked the commands/differences but would expect them to be quite similar, if not it would indeed make more sense to separate it.

@tolgap
Copy link
Contributor Author

tolgap commented Apr 18, 2024

@TriPSs I think we should separate it. What should I name the executor? deployJob? Or maybe deploy-job?

@TriPSs
Copy link
Owner

TriPSs commented May 6, 2024

@tolgap would do deploy-job

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants