-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Testing: Address case when setting COMM serial and NUM_MPI_PROCS N for N > 1 #542
Labels
Comments
bartlettroscoe
changed the title
Testing: Error out when setting COMM serial and NUM_MPI_PROCS N for N > 1
Testing: Address case when setting COMM serial and NUM_MPI_PROCS N for N > 1
Dec 1, 2022
@rppawlo and @etphipp, can you please look above and add a thumbs up if those behaviors are consistent with what we have agreed to in trilinos/Trilinos#11322 (comment)? If not, please comment on what should be fixed. |
I can't speak to the urgency #367, but I think this is somewhat urgent just because we have a bunch of tests that aren't being run in serial builds. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
As described in trilinos/Trilinos#11322 (comment), the updated behavior of TriBITS is to not add a test in an non-MPI SERIAL build when the test has an explicit
NUM_MPI_PROCS N
forN > 1
. But test will never be added ifCOMM serial
is passed intotribits_add[_advanced]_test()
in these cases.This Issue is to update
tribits_add[_advanced]_test()
to address the case whereCOMM serial
andNUM_MPI_PROCS N
forN > 1
are passed in.Proposed solution
Many different proposed solutions are discussed in comments after trilinos/Trilinos#11322 (comment). What we arrived at is to implement the following:
Case 1:
NUM_MPI_PROCS N
forN > 1
but no explicitCOMM ...
argument passed in:N
procs (which is the current TriBITS behavior)Case 2:
NUM_MPI_PROCS N
forN > 1
with explicitCOMM serial mpi
passed in:N
procs and one with1
proc (currently just theN
proc test is added)1
proc will be added (currently no test is added)Case 3:
NUM_MPI_PROCS N
forN > 1
with explicitCOMM serial
(but notmpi
) passed in:The text was updated successfully, but these errors were encountered: