Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Feature]: Clear and prompt for DisplayVersion under AppsAndFeaturesEntries if defined #116

Open
OfficialEsco opened this issue Nov 22, 2021 · 2 comments
Labels
Enhancement New feature or request Schema 1.1.0

Comments

@OfficialEsco
Copy link
Collaborator

Description of the new feature/enhancement

Test manifest/reference manifest: AnyDeskSoftwareGmbH.AnyDesk (not direct link since it may change)

The first step into AppsAndFeaturesEntries we can take is probably clearing and prompting for the DisplayVersion under AppsAndFeaturesEntries IF its defined

Once winget-cli and wingetcreate actually supports manifest schema 1.1.0 we can probably move the ProductCode to AppsAndFeaturesEntries

Proposed technical implementation details (optional)

No response

@OfficialEsco OfficialEsco added Enhancement New feature or request Schema 1.1.0 labels Nov 22, 2021
@OfficialEsco OfficialEsco added this to To do in v2.1.0 via automation Nov 22, 2021
@Trenly
Copy link
Owner

Trenly commented Nov 22, 2021

I think that we may want to address how we handle version detection as a whole.

Theres probably a few parts to this:

  1. Remove the version input at the beginning
  2. Find the latest version of the app inside the app folder
  3. Make display version key mandatory for the first installer. Have a suggested value as the one defined by the downloaded installer file if it exists. If it is not the first installer, it should be optional, but if not entered it will take the same value as the first installer.
  4. If all display versions are the same and are not null or empty strings, use that as the package version. Otherwise, ask the user to input the package version

@OfficialEsco
Copy link
Collaborator Author

Hmmm, sounds good to me i think 🤔 We do your thing then

@OfficialEsco OfficialEsco removed this from To do in v2.1.0 Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request Schema 1.1.0
Projects
None yet
Development

No branches or pull requests

2 participants