Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use FileVersion as suggested version number? #108

Open
jedieaston opened this issue Oct 31, 2021 · 2 comments
Open

Use FileVersion as suggested version number? #108

jedieaston opened this issue Oct 31, 2021 · 2 comments
Labels
Enhancement New feature or request

Comments

@jedieaston
Copy link
Collaborator

jedieaston commented Oct 31, 2021

Description of the new feature/enhancement

I just found something out and even if it can't make 2.0, I think it's worth noting for the future if anyone feels like implementing it (maybe I will)..

The FileVersion ProductVersion attribute is often the same as the ARP version number, and it's super easy to get in PowerShell.

S C:\Users\easton> iwr https://github.com/git-for-windows/git/releases/download/v2.33.1.windows.1/Git-2.33.1-64-bit.exe -OutFile .\git.exe
PS C:\Users\easton> (Get-Item .\git.exe).VersionInfo

ProductVersion   FileVersion      FileName
--------------   -----------      --------
2.33.1       ... 2.33.1.1     ... C:\Users\easton\git.exe


PS C:\Users\easton>

YamlCreate should be able to do this for the user, so that they can hand it a URL (or URLs) for an update and it can handle the rest. wingetcreate already does something like this too.

Proposed technical implementation details (optional)

Just do Get-Item on the file, and look to see if ProductVersion is set. If it is, either suggest that they use that number, or if it's a quick update, then use that number by default.

@vedantmgoyal9
Copy link

Good idea...👍

@Trenly
Copy link
Owner

Trenly commented Oct 31, 2021

It would require a bit of rework to incorporate this, but I love the idea. I'll add it to the roadmap

@Trenly Trenly self-assigned this Oct 31, 2021
@Trenly Trenly added the Enhancement New feature or request label Oct 31, 2021
@Trenly Trenly removed their assignment Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants