Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize flaky tests #713

Closed
TomerFi opened this issue Sep 21, 2023 · 4 comments · Fixed by #785
Closed

Stabilize flaky tests #713

TomerFi opened this issue Sep 21, 2023 · 4 comments · Fixed by #785
Labels
help wanted Contributing help wanted type: enhancement New feature or request

Comments

@TomerFi
Copy link
Owner

TomerFi commented Sep 21, 2023

What did you have in mind?

The following test-cases are failing when the running machine's timezone differs from Asia/Jerusalem. Although the underlying devices are meant to work in Asia/Jerusalem, this situation prevents collaborators outside this timezone from passing tests locally. If I remember correctly, these test-cases also fail at a specific time, I think it was 00:00-00:01, but I'm not sure.

def test_schedule_parser_with_a_weekly_recurring_enabled_schedule_data():

def test_schedule_parser_with_a_daily_recurring_enabled_schedule_data():

def test_schedule_parser_with_a_partial_daily_recurring_enabled_schedule_data():

def test_schedule_parser_with_a_non_recurring_enabled_schedule_data():

Are you trying to fix a problem?

No response

Any lead on how this feature can be implemented?

No response

@TomerFi TomerFi added type: enhancement New feature or request help wanted Contributing help wanted labels Sep 21, 2023
@YogevBokobza
Copy link
Collaborator

Yes I saw this issue when developed the latest PRs..
Need to fix that..

@YogevBokobza
Copy link
Collaborator

@TomerFi Is that the fix done in #752 ?

@TomerFi
Copy link
Owner Author

TomerFi commented Feb 12, 2024

I don't think so...

@TomerFi
Copy link
Owner Author

TomerFi commented Mar 3, 2024

@YogevBokobza #627 seems related to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Contributing help wanted type: enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants