Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

analysis: Check that the PR is a single commit #35

Open
iphydf opened this issue Dec 23, 2016 · 1 comment
Open

analysis: Check that the PR is a single commit #35

iphydf opened this issue Dec 23, 2016 · 1 comment

Comments

@iphydf
Copy link
Member

iphydf commented Dec 23, 2016

During the development and review progression, it's fine to add commits to see the history, but when we actually merge it, it should be a single commit based on master.
@iphydf
Copy link
Member Author

iphydf commented Jan 4, 2017

This should be a warning, not necessarily blocking the PR. There may be good reasons to have multiple commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@iphydf