Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Support set encoding format in CLI #55

Closed
Scighost opened this issue Oct 26, 2022 · 0 comments
Closed

Proposal: Support set encoding format in CLI #55

Scighost opened this issue Oct 26, 2022 · 0 comments

Comments

@Scighost
Copy link
Contributor

Feature Request

I'm developing an app to play cutscenes and found PCM audio cannot decode in WinUI. I can export video and audio separately and combine them into mkv files after encoding. However, it's the best way to finish all steps in CLI.

Code Design

Add two command option --audio-format and --video-format to command demuxUsm and batchDemux.

Options description:

# GICutsences.exe demuxUsm -h
Options: 
  -af, --audio-format <audio-format>           Encode audio stream in MKV file, the original format is PCM.
  -vf, --video-format <video-format>           Encode video stream in MKV file, the original format is VP9.
  # other options ...

These two options will take effect only after adding --merge. If user don't add any encoding format, the origin stream would be copied to output file. If user add encoding format, program will use ffmpeg engine instead of --mkv-engine.

Usage Example

GICutsences.exe demuxUsm <InputFile> -af aac -vf h264 -o ./
Ignore -af and -vf option because of no -m

GICutsences.exe demuxUsm <InputFile> -m -af flac -o ./
Audio stream will be encoded to flac format.

GICutsences.exe demuxUsm <InputFile> -m -af flac -e mkvmerge -o ./
Ignore -e mkvmerge, use ffmpeg insead.

Known Problem

When add --video-format, it takes a lot of time to encode video stream and shows no progress. But I think nobody would re-encode video stream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants