Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NucleusInstanceSegmentor.predict() has no "patch" mode #780

Open
alevangel opened this issue Feb 1, 2024 · 2 comments · May be fixed by #578
Open

NucleusInstanceSegmentor.predict() has no "patch" mode #780

alevangel opened this issue Feb 1, 2024 · 2 comments · May be fixed by #578
Labels
bug Something isn't working enhancement New feature or request

Comments

@alevangel
Copy link

alevangel commented Feb 1, 2024

  • TIA Toolbox version: 1.5.1
  • Python version: 3.8
  • Operating System: Windows

What I Did

I would like to do some test with patch mode prediction for Nucleus Instance Segmentation, but I see that is still not implemented?

Here is stated that can be used:

Args:
imgs (list, ndarray):
List of inputs to process. When using `"patch"` mode,
the input must be either a list of images, a list of
image file paths or a numpy array of an image list. When
using `"tile"` or `"wsi"` mode, the input must be a list
of file paths.

But here we assume that could be only 'tile' or 'wsi':

if mode not in ["wsi", "tile"]:
msg = f"{mode} is not a valid mode. Use either `tile` or `wsi`."
raise ValueError(msg)

@shaneahmed shaneahmed linked a pull request Feb 2, 2024 that will close this issue
@shaneahmed
Copy link
Member

We are working on improving the structure of engines in #578

@shaneahmed
Copy link
Member

shaneahmed commented Feb 2, 2024

We are working on improving the structure of engines in #578

The patch mode should still work as NucleusInstanceSegmentor is inheriting from SemanticSegmentor [doc]

@Abdol Abdol added bug Something isn't working enhancement New feature or request labels Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants