Skip to content

Config refactoring #107

Merged
merged 9 commits into from
Jul 13, 2023
Merged

Config refactoring #107

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
39cedb4
config refactoring
Squiry Jan 19, 2023
7476316
fix
Squiry Jul 13, 2023
8b119b3
fix
Squiry Jul 13, 2023
51e95a7
kafka fix
Squiry Jul 13, 2023
4596b2e
fix
Squiry Jul 13, 2023
b2ebf11
fix
Squiry Jul 13, 2023
8dd92fd
fix
Squiry Jul 13, 2023
972710d
fix
Squiry Jul 13, 2023
ebfbbdf
fix
Squiry Jul 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
kafka fix
  • Loading branch information
@Squiry
Squiry committed Jul 13, 2023
commit 51e95a7ba66029491b3b192acc32030db812981d
2 changes: 1 addition & 1 deletion ...in/kotlin/ru/tinkoff/kora/kafka/symbol/processor/consumer/KafkaConsumerConfigGenerator.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ class KafkaConsumerConfigGenerator {
CommonClassNames.configValueExtractor.parameterizedBy(kafkaConsumerConfig)
)
.addStatement("val configValue = config.get(%S)", configPath)
.addStatement("return extractor.extract(configValue)")
.addStatement("return extractor.extract(configValue)!!")
.addAnnotation(listOf(tagName).toTagAnnotation())
.build()
return KafkaConfigData(tagBuilder, funBuilder)
Expand Down
4 changes: 2 additions & 2 deletions ...rc/main/kotlin/ru/tinkoff/kora/kafka/symbol/processor/consumer/KafkaContainerGenerator.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,8 @@ class KafkaContainerGenerator {
.returns(CommonClassNames.lifecycle)

funBuilder.addStatement("val wrappedHandler = %T.wrapHandler(telemetry, %L, handler)", KafkaClassNames.handlerWrapper, consumerParameter == null)
funBuilder.controlFlow("if (config.driverProperties.getProperty(%T.GROUP_ID_CONFIG) == null)", KafkaClassNames.commonClientConfigs) {
addStatement("val topics = config.topics")
funBuilder.controlFlow("if (config.driverProperties().getProperty(%T.GROUP_ID_CONFIG) == null)", KafkaClassNames.commonClientConfigs) {
addStatement("val topics = config.topics()")
addStatement("require(topics != null)")
addStatement("require(topics.size == 1)")
addStatement("return %T(config, topics[0], keyDeserializer, valueDeserializer, telemetry, wrappedHandler)", KafkaClassNames.kafkaAssignConsumerContainer)
Expand Down
Loading