-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid forcing VCPKG and allow using external dependencies #4960
Comments
[SC-36911](https://app.shortcut.com/tiledb-inc/story/36911/remove-enable-vcpkg-options-from-cmake-command-line-and-bootstrap-scripts) This PR changes the severity of the message when we configure with `-DTILEDB_VCPKG=OFF` from a `DEPRECATION` to a `FATAL_ERROR`. This means that using the legacy `ExternalProject`-based mechanism for acquiring dependencies is no longer supported. The `ExternalProject` modules have become dead code and will be removed in a subsequent PR. --- TYPE: BUILD DESC: Vcpkg is always enabled; turning the `TILEDB_VCPKG` option off is no longer supported and fails.
@MehdiChinoune sorry for the frustration. The packaging of lz4 has a known issue where the official and vcpkg distributions have different casing of the package names. I have made work towards unifying their behavior and will continue to do so by engaging with both lz4 and vcpkg. In the meantime you can apply a patch we have been using for Conda, that will make CMake use the standard I must also say that the name Let me know if you have further questions. |
Opened macports/macports-ports#24239 to migrate the tiledb port to not need to patch disabling |
The MacPorts PR has been merged, I believe we can close this issue. Let us know if you encounter another problem. |
@teo-tsirpanis Thank you very much. P. S. By the way, if you or anyone will be interested to help us maintain TileDB port, welcome to be a co-maintainer. |
Please do not force everyone to rely on VCPKG. The build should be customizable.
The following commit brought this undesirable change: 5997aff
Using external dependencies should be supported, that is how most downstream software distributions work. We do not want VCPKG to choose some random stuff to build for us in MacPorts, for example. Otherwise this kind of tickets arise.
The text was updated successfully, but these errors were encountered: