Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix - "VALUES: rowvalues #1: rowvalue #2: types.MDString has no SQL representation" Error #520

Conversation

maxdemaio
Copy link
Member

@maxdemaio maxdemaio commented Nov 22, 2023

These changes will allow us to dump odict files to SQL format by fixing the issue with markdown formatted values in Descriptions and Definition Values.

I think this will be one step further to getting a docker-compose file for our web repo! This closes #519

Steps to reproduce

  • Compile examples/example2.xml to odict format
  • Dump said odict file to SQL go run odict.go d -f postgres examples/example2.odict examples/output.sql
  • See error in terminal

@Nickersoft
Copy link
Member

Woah @maxdemaio, sorry I just saw this – small request actually if you're touching this file! Do you think you could also update the generator to account for the new NoteRepresentable struct as well? It's part of Definitions. We can put it in a notes table.

@Nickersoft Nickersoft merged commit f018e00 into main Jan 11, 2024
1 check failed
@Nickersoft Nickersoft deleted the 519-odict-dump-error-sql-values-rowvalues-1-rowvalue-2-typesmdstring-has-no-sql-representation branch January 11, 2024 22:15
@github-actions github-actions bot mentioned this pull request Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

ODict Dump Error SQL - "VALUES: rowvalues #1: rowvalue #2: types.MDString has no SQL representation"
2 participants