-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linting and RuboCop: Unclear what "the" Gem is. #28269
Comments
Hi @scheals "Since RuboCop is extensible, there exist other departments that you can use - like Performance or RSpec." I think this line might be less ambiguous if were phrased like: "There are many gems you can install that will extend RuboCop like rubocop-rspec or rubocop-performance. Also, on line 180 I think it would be helpful to specify that the line in the proceeding codeblock should be added to the GemFile (and not the |
That line codeblock after line 180 should go to the Gemfile. Now, it might be because I was duped by VSCode extensions in the past but I do not recall having to do anything else for RuboCop to pick those extensions up, but the official docs seem to suggest an entry in the So yeah, this needs to be added as well. |
@scheals Okay, I think I have a good idea of how to help make this section a bit more clear and that would address the issues we've discussed so far. I can submit a PR for you to review. If you like the changes we can merge it, or if you think it could be better we can discuss further. Sound good? |
@SumonGFC |
@scheals right okay haha. I value your input however, as you are the one who wrote this lesson. |
Feel free to submit a PR @SumonGFC |
PR submitted. Please let me know if you have any thoughts/criticisms/suggestions to improve it. |
Checks
Describe your suggestion
There is an example of locally installing a plugin for RuboCop in You are the code dictator section that confuses learners due to the wording:
I'm ESL and when I wrote this my train of thought was "the Gem you are interested in, Performance, RSpec, your own Cop". Perhaps it should be "a Gem" or "the Gem(s) you chose".
Example confusion seen on discord
Path
Ruby / Rails
Lesson Url
https://www.theodinproject.com/lessons/ruby-linting-and-rubocop
(Optional) Discord Name
No response
(Optional) Additional Comments
No response
The text was updated successfully, but these errors were encountered: