Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cooking should depend on Hunger and Thirst or none of them #113

Open
oniatus opened this issue Dec 29, 2016 · 2 comments
Open

Cooking should depend on Hunger and Thirst or none of them #113

oniatus opened this issue Dec 29, 2016 · 2 comments
Labels
Category: Gameplay Content Requests, Issues and Changes targeting gameplay mechanics and content Good First Issue Good for learners that are new to Terasology Size: S Small effort likely only affecting a single area and requiring little to no research Topic: UI/UX Requests, Issues and Changes related to screens, artwork, sound and overall user experience Type: Improvement Request for or addition/enhancement of a feature

Comments

@oniatus
Copy link
Contributor

oniatus commented Dec 29, 2016

Cooking depends on Hunger at the moment.
Nearly all food items provide the FoodComponent from the Hunger module.

However, nearly all food items also provide the DrinkComponent from the Thirst module.

Activating Cooking only will not activate (or download) the Thirst module, leaving the player with a hunger-bar only.

It's likely that cooking will function without hunger or thirst but this is probably very pointless :) For consistency, we should add thirst to the dependencies which also would make the testing much easier.

@Cervator
Copy link
Member

Cervator commented Sep 6, 2017

Bumping this and adding it to new project board https://github.com/orgs/Terasology/projects/9 for @jellysnake :D

Likely outcome: Depend on a new "Sustenance" module that holds the shared functionality

@jdrueckert
Copy link
Member

In addition to adding a dependency to Thirst, FillingModifier needs to be adjusted to also fill the thirst bar based on the DrinkComponents filling value for the ingredients.

@jdrueckert jdrueckert added Type: Improvement Request for or addition/enhancement of a feature Category: Gameplay Content Requests, Issues and Changes targeting gameplay mechanics and content Size: S Small effort likely only affecting a single area and requiring little to no research Topic: UI/UX Requests, Issues and Changes related to screens, artwork, sound and overall user experience Good First Issue Good for learners that are new to Terasology labels Jun 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Gameplay Content Requests, Issues and Changes targeting gameplay mechanics and content Good First Issue Good for learners that are new to Terasology Size: S Small effort likely only affecting a single area and requiring little to no research Topic: UI/UX Requests, Issues and Changes related to screens, artwork, sound and overall user experience Type: Improvement Request for or addition/enhancement of a feature
Projects
No open projects
Development

No branches or pull requests

3 participants