-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small animation improvements #6
Labels
Comments
Thanks a lot for using this component and for the feedback. :)
|
A good idea I had to fix the color is to possibly use CSS masks to invert the color of the text. I messed with the implementation a little but didn't land on anything solid |
@PorterK Same here. I wasted several hours on that. 😓 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When you click a lot in the minute picker (That is, repeatedly and quickly click at a lot of different positions) the animation sometimes skips, the minute hand just appears at the final position without animating from it's current position.
I think the correct behavior should be to take the current position of the minute hand (wherever that is, stationery or in the middle of another animation due to a previous click) and use that as starting position (stop the old animation if necessary) and then just go from there.
The second thing I noticed is that whenever you click at a number, say 5 or 30 or whatever (in both the minute and hour pickers) the font color of the number changes to white immediately on the click. So, for a few 100s of milliseconds, we see white text on the light grey-ish background, which doesn't look very good.
Here's an idea, change the color to white just before the hand reaches that number. I mean as the big blue circle is about to overlap with the number (as over
25
below), that is when the text should change to white. The change of color should coincide with the end of the hand's animation, or maybe a little bit before.Let me know if you don't quite get what I mean and I'll make a video.
The text was updated successfully, but these errors were encountered: