Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpusEncoder and OpusBufferedEncoder Interfaces #72

Open
mattgwwalker opened this issue Dec 12, 2020 · 0 comments
Open

OpusEncoder and OpusBufferedEncoder Interfaces #72

mattgwwalker opened this issue Dec 12, 2020 · 0 comments
Milestone

Comments

@mattgwwalker
Copy link
Collaborator

OpusEncoder is currently the base class for OpusBufferedEncoder.

Naturally, they should both have an encode() method. However the two classes return different results. OpusEncoder returns a single encoded frame, while OpusBufferedEncoder may return multiple encoded frames.

Their interfaces need to be tidied up. Perhaps the direct-inheritance should be replaced with a common base class.

@mattgwwalker mattgwwalker added this to the Version 0.7 milestone Dec 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant