[FEAT/#68] 투두 전체 조회 / 서버통신 구현 #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leeeyubin
approved these changes
Jan 10, 2024
Comment on lines
+32
to
+35
|
|
||
| fun toTodoModel() = | ||
| TodoModel(todoId, title, endDate, allocators.map { it.toTodoAllocatorModel() }, secret) | ||
| } |
Comment on lines
+46
to
+47
|
|
||
| fun getCompleteTodoListFromServer(tripId: Long, category: String, progress: String) { |
Comment on lines
+59
to
+61
| private fun observeTodoListState() { | ||
| viewModel.todoCompleteListState.flowWithLifecycle(lifecycle).onEach { state -> | ||
| when (state) { |
crownjoe
approved these changes
Jan 10, 2024
Comment on lines
32
to
+40
| @Singleton | ||
| fun provideSettingDataSource(settingDataSourceImpl: SettingDataSourceImpl): SettingDataSource = | ||
| settingDataSourceImpl | ||
|
|
||
| @Provides | ||
| @Singleton | ||
| fun provideTodoDataSource(todoDataSourceImpl: TodoDataSourceImpl): TodoDataSource = | ||
| todoDataSourceImpl | ||
|
|
There was a problem hiding this comment.
시작됐다....서버통신.!........!!!!!
Comment on lines
59
to
62
| private fun setViewPager() { | ||
| binding.vpMyTodo.adapter = MyTodoViewPagerAdapter(this) | ||
| binding.vpMyTodo.isUserInputEnabled = false | ||
| TabLayoutMediator(binding.tabMyTodo, binding.vpMyTodo) { tab, pos -> |
There was a problem hiding this comment.
우와 스와이프 막는 코드.. 뷰페이저 조아요~
Comment on lines
+23
to
+24
| private val _todoUncompleteListState = MutableStateFlow<UiState<List<TodoModel>>>(UiState.Empty) | ||
| val todoUncompleteListState: StateFlow<UiState<List<TodoModel>>> = _todoUncompleteListState |
Comment on lines
+33
to
+64
| fun getUncompleteTodoListFromServer(tripId: Long, category: String, progress: String) { | ||
| _todoUncompleteListState.value = UiState.Loading | ||
| viewModelScope.launch { | ||
| todoRepository.getTodoList(tripId, category, progress) | ||
| .onSuccess { response -> | ||
| _todoUncompleteListState.value = UiState.Success(response) | ||
| _totalUncompletedTodoCount.value = response.size | ||
| } | ||
| .onFailure { | ||
| _todoUncompleteListState.value = UiState.Failure(it.message.orEmpty()) | ||
| } | ||
| } | ||
| } | ||
|
|
||
| fun getCompleteTodoListFromServer(tripId: Long, category: String, progress: String) { | ||
| _todoCompleteListState.value = UiState.Loading | ||
| viewModelScope.launch { | ||
| todoRepository.getTodoList(tripId, category, progress) | ||
| .onSuccess { response -> | ||
| _todoCompleteListState.value = UiState.Success(response) | ||
| } | ||
| .onFailure { | ||
| _todoCompleteListState.value = UiState.Failure(it.message.orEmpty()) | ||
| } | ||
| } | ||
| } | ||
|
|
||
| companion object { | ||
| const val MY_TODO = "my" | ||
| const val UNCOMPLETE = "incomplete" | ||
| const val COMPLETE = "complete" | ||
| } |
There was a problem hiding this comment.
...서버통신 코드...장난 아니네요 조아여~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⛳️ Work Description
📸 Screenshot
KakaoTalk_Video_2024-01-11-08-46-15.mp4
📢 To Reviewers