Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🛠️] Minor Issues and Enhancements Backlog #29

Open
TanmoySG opened this issue Jan 14, 2023 · 6 comments
Open

[🛠️] Minor Issues and Enhancements Backlog #29

TanmoySG opened this issue Jan 14, 2023 · 6 comments
Assignees

Comments

@TanmoySG
Copy link
Owner

This Issue tracks some identified minor Issues and Enhancements that can be picked up in future.

@TanmoySG TanmoySG self-assigned this Jan 14, 2023
@TanmoySG
Copy link
Owner Author

TanmoySG commented Jan 14, 2023

Enhancements to Filter

If filters can be send as JSON then the type can also be checked and taken into account while filtering and we can use a type-full/type-respective data comparison instead of a type-less/type-irrespective data comparison in data filtering

image

@TanmoySG TanmoySG pinned this issue Jan 14, 2023
@TanmoySG
Copy link
Owner Author

@TanmoySG
Copy link
Owner Author

TanmoySG commented Feb 4, 2023

Expand docker build to more platforms/archs

https://docs.docker.com/build/building/multi-platform/

@TanmoySG
Copy link
Owner Author

TanmoySG commented Feb 9, 2023

Importable Packages from wunderDB (for Go)

  • a hooks package containing various hooks
    • hook.Server pkg that abstracts the server-lifecycle (in internal) to an importable projects - can be used with CLI
    • othe hooks
  • an Error package
  • other

@TanmoySG
Copy link
Owner Author

TanmoySG commented Apr 1, 2023

Fix Lint Issues

internal/roles/roles.go:209:16: Error return value of `json.Unmarshal` is not checked (errcheck)
        json.Unmarshal(mergedGrantBytes, &privileges)
                      ^
internal/wfs/unloader.go:18:12: Error return value of `os.Create` is not checked (errcheck)
                os.Create(w.namespacesBasePath)
                         ^
internal/wfs/unloader.go:35:12: Error return value of `os.Create` is not checked (errcheck)
                os.Create(w.databasesBasePath)
                         ^
internal/wfs/unloader.go:52:12: Error return value of `os.Create` is not checked (errcheck)
                os.Create(w.rolesBasePath)
                         ^
internal/server/middlewares/recovery/recovery.go:90:12: Error return value of `c.Send` is not checked (errcheck)
                                        c.Send(r.Marshal())
                                              ^
internal/server/handlers/common.go:70:8: Error return value of `c.Send` is not checked (errcheck)
        c.Send(marshaledResponse)
              ^
internal/users/users.go:9:2: const `tokenAuthentication` is unused (unused)
        tokenAuthentication    = "token"
        ^
internal/users/users.go:8:2: const `passwordAuthentication` is unused (unused)
        passwordAuthentication = "password"
        ^
internal/wfs/loader.go:88:6: func `loadEntity` is unused (unused)
func loadEntity(entityPath string, entity any) (any, error) {
     ^
internal/server/lifecycle/shutdown/shutdown.go:18:3: S1005: unnecessary assignment to the blank identifier (gosimple)
                _ = <-ch

@TanmoySG
Copy link
Owner Author

Explore in-code execution of tools

This branch https://github.com/TanmoySG/wunderDB/tree/tools-within-code-usage-backup has the required code/sample to run wdb-tools from within code.

Can explore for other purposes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant