-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
eslint plugin: false positive for function calls #7340
Labels
Comments
@Newbie012 is there a way to make this work ? |
TkDodo
changed the title
eslint plugin: false positive for functioncalls
eslint plugin: false positive for function calls
Apr 26, 2024
Yes (Stackblitz). I had a similar issue where I had to cache signed S3 (AWS) URLs. I ended up doing something (roughly) like: import { useQuery } from '@tanstack/react-query';
class QueryableValue<T> {
constructor(private value: T, private map: (v: T) => string) {}
toJSON = () => this.map(this.value);
toString = () => this.value;
valueOf = () => this.value;
}
const path = new QueryableValue(
'https://signed-url.com?Expiration=123',
(x) => x.split('?Expiration')[0]
);
export const Test = () => {
const query = useQuery({
queryKey: [path],
queryFn: () => path.toString(),
});
return <div>{query.data}</div>;
}; |
so toJSON will be called by query? |
Correct, since query uses |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
The following yields a false-positive eslint violation:
error with:
Your minimal, reproducible example
failing test case attached
Steps to reproduce
Here's a failing test case:
Expected behavior
Ideally, I would like to see no error here, because
path
winds up in thequeryKey
. Not sure if it's possible thoughHow often does this bug happen?
None
Screenshots or Videos
No response
Platform
all
Tanstack Query adapter
None
TanStack Query version
5.29.2
TypeScript version
5.3.3
Additional context
No response
The text was updated successfully, but these errors were encountered: